Tests | Active Issues (Part 3) #3642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nNotSupportedTest, LocalDbNamedPipeMarsTest
…it to be async and properly cancel stuck tasks
…ork) Adjusted cut max interval and delta to 1/10 of original values to speed up test.
Add helper for getting a list of transient error codes in addition to the defaults
…o-longer-used helpers
There was a problem hiding this comment.
Pull Request Overview
This PR continues the effort to clean up [ActiveIssue] tests by re-enabling previously disabled tests and modernizing them to use TheoryData instead of object arrays. The focus is primarily on reliability tests for SQL connection and command operations.
Key Changes
- Re-enabled multiple test methods by removing
[ActiveIssue]attributes - Converted test data generation from object arrays to strongly typed
TheoryData<string, SqlRetryLogicBaseProvider> - Modernized the
TestPacketNumberWraparoundtest to use proper async/await patterns with improved timeout handling
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SqlConnectionReliabilityTest.cs | Added TheoryData properties and removed ActiveIssue attributes for reliability tests |
| SqlConfigurationManagerReliabilityTest.cs | Fixed method name casing and added TODO comment |
| SqlCommandReliabilityTest.cs | Converted to TheoryData, removed ActiveIssue attributes, and improved method naming |
| RetryLogicTestHelper.cs | Refactored helper methods to return TheoryData instead of object arrays |
| TvpTest.cs | Modernized TestPacketNumberWraparound to use async/await with proper cancellation |
| LocalDBTest.cs | Re-enabled LocalDB tests by removing ActiveIssue attributes |
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/SqlConnectionReliabilityTest.cs
Outdated
Show resolved
Hide resolved
paulmedynski
requested changes
Sep 30, 2025
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/SqlConnectionReliabilityTest.cs
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3642 +/- ##
==========================================
+ Coverage 66.43% 66.58% +0.14%
==========================================
Files 271 275 +4
Lines 60277 60120 -157
==========================================
- Hits 40048 40029 -19
+ Misses 20229 20091 -138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
Oct 1, 2025
paulmedynski
approved these changes
Oct 1, 2025
cheenamalhotra
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this installment of cleaning up
[ActiveIssue]tests, I focus mostly on the reliability tests, including upgrading the test cases to useTheoryDataover a network of object arrays. Here's the tests that were re-enabled:Issues
Continuation of work from #3624
Testing
Tests all pass locally! It's possible these will fail in CI, but we won't know until we try :)